Re: [O] [PATCH] expose nrepl's timeout setting in ob-clojure.el

[Nicolas Goaziou]

Hello,

Thank you for the update.

Frederick Giasson <address@hidden> writes:

> +(defcustom org-babel-clojure-sync-nrepl-timeout 10
> +  "Timeout value, in seconds, of a Clojure sync call. 
> +   If the value is nil, timeout is disabled."
> +  :type 'integer
> +  :group 'org-babel)

Some keywords are missing:

  :version "25.1"
  :package-version '(Org . "9.0")

and perhaps

  :safe #'wholenump

>  (defcustom org-babel-clojure-backend
>    (cond ((featurep 'cider) 'cider)
>       (t 'slime))
> @@ -94,8 +100,9 @@
>         (let ((result-params (cdr (assoc :result-params params))))
>        (setq result
>              (nrepl-dict-get
> -             (nrepl-sync-request:eval
> -              expanded (cider-current-connection) (cider-current-session))
> +             (let ((nrepl-sync-request-timeout 
> org-babel-clojure-sync-nrepl-timeout))
> +               (nrepl-sync-request:eval
> +                expanded (cider-current-connection) (cider-current-session)))

You forgot to

(defvar nrepl-sync-request-timeout)

I also think it makes sense to merge the 3 patches.

Regards,

-- 
Nicolas Goaziou