[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [O] New package: ox-minutes [Please critique]
From: |
Oleh Krehel |
Subject: |
Re: [O] New package: ox-minutes [Please critique] |
Date: |
Wed, 10 Aug 2016 18:16:07 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) |
Kaushal Modi <address@hidden> writes:
> Hi all,
>
> I have never published a package. I generally write elisp snippets embedded
> in my config.
>
> Here are my first attempts at a 'package' and defining a custom org
> export backend.
Congrats on your first package! It will surely come in handy when
interacting with my less Emacs-enlightened colleagues. I recall one of
them writing very similar-looking notes in Microsoft Outlook. One or two
times I had to send them some notes, I actually did by hand the
transformation that `ox-minutes' now does.
> I would love to get criticism on this... What did I miss? Bad coding
> practices?
The coding looks fine. Just a suggestion: I think "\n" looks better than
a literal string newline.
It would be cool to have a regression test with:
./ox-minutes/ox-minutes-test.el
./ox-minutes/test_input.org
./ox-minutes/test_output.txt
Both test_input.org and test_output.txt could be moved from README.md.
regards,
Oleh