Re: [O] [PATCH] custom port for postgresql

[Jakob Lombacher]

Hi Adam,

thanks for the "patch" hint ;-)

I changed the dbport as optional argument and added the dbpassword option as well.

Jakob

2016-09-14 7:04 GMT+02:00 Adam Porter <address@hidden>:

Jakob Lombacher <address@hidden> writes:

> -(defun org-babel-sql-dbstring-postgresql (host user database)
> +(defun org-babel-sql-dbstring-postgresql (host port user database)

Hi Jakob,

Two suggestions:

1.  Generally people put something like "[PATCH]" in the subject so that
the maintainers will know it contains a patch.  :)

2.  I'd suggest putting the new `port` argument at the end of the
argument list, after an `&optional`.  Even though it makes more sense to
put it after the host, putting it at the end and making it optional
means that people won't have to change existing code that calls this
function.

Thanks for submitting the patch.

0001-add-dbport-and-dbpassword-options-to-psql.patch
Description: Text Data