Re: [O] [PATCH] Add support for ordered list to ox-confluence.el

[Charles Durst]

Oops, I just realized an important difference.  My version also
supported descriptive lists.  The version with only Nicholas' changes
will lose the item name:

* item-name :: description

Will just become

- description

Here is a fix based on Nicholas' version:


* contrib/lisp/ox-confluence.el (org-confluence-item): Support
  descriptive list

When converting a descriptive list item, be sure to include the "item"
part, not just the description.

TINYCHANGE
---
 contrib/lisp/ox-confluence.el | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/contrib/lisp/ox-confluence.el b/contrib/lisp/ox-confluence.el
index de8b00e..a1318f9 100644
--- a/contrib/lisp/ox-confluence.el
+++ b/contrib/lisp/ox-confluence.el
@@ -83,9 +83,13 @@
 (defun org-confluence-item (item contents info)
   (let* ((plain-list (org-export-get-parent item))
          (type (org-element-property :type plain-list))
-         (bullet (if (eq type `ordered) ?\# ?\-)))
+         (bullet (if (eq type 'ordered) ?\# ?\-)))
     (concat (make-string (1+ (org-confluence--li-depth item)) bullet)
             " "
+    (if (eq type 'descriptive)
+ (concat "*"
+ (org-export-data (org-element-property :tag item) info)
+ "* - "))
             (org-trim contents))))

 (defun org-confluence-fixed-width (fixed-width contents info)
-- 
2.5.4 (Apple Git-61)


On Sat, Dec 10, 2016 at 2:54 AM, Lungang Fang <address@hidden> wrote:
> Hi Nicolas and Charles,
>
> Thank you both.
>
> Lungang
>
> On Sat, Dec 10, 2016 at 7:34 AM, Nicolas Goaziou <address@hidden>
> wrote:
>>
>> Hello,
>>
>> Lungang Fang <address@hidden> writes:
>>
>> > Great! Then, what about using my patch ? It would be my first patch
>> > adopted
>> > by any open source project, a real milestone  :)
>>
>> Applied. Thanks to both of you.
>>
>> Regards,
>>
>> --
>> Nicolas Goaziou
>
>