emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [O] [PATCH] allow klipse export in html


From: Matt Price
Subject: Re: [O] [PATCH] allow klipse export in html
Date: Thu, 15 Dec 2016 09:56:18 -0500

(actually attaching the patch)
(seemed silly to have a whole bunch of tiny patches but can resubmit as a series if that's preferred).

On Thu, Dec 15, 2016 at 9:42 AM, Matt Price <address@hidden> wrote:


On Thu, Dec 15, 2016 at 8:39 AM, Nicolas Goaziou <address@hidden> wrote:
Hello,

Matt Price <address@hidden> writes:

> I'm such a slow coder that this is all I got to in my free moments
> today:patch for defcustoms that inserts the necessary code into a src
> block.  further refinements necessary before it works properly; severla
> more would be useful for hte improvements that Bastien suggests.

Thank you. Some comments follow.

> +(defcustom org-html-klipsify-src nil
> +  "Set to non-nil if you would like to make source code blocks editable in exported presentation."

When non-nil, source code blocks are editable in exported presentation.

> +  :group 'org-export-html
> +  :type 'boolean)

:version :package-version keywords are missing.

> +(defcustom org-html-klipse-css "https://storage.googleapis.com/app.klipse.tech/css/codemirror.css"
> +  "Location of the codemirror css file for use with klipse."

css -> CSS

> +  :group 'org-export-html
> +  :type 'string)

See above.

> +(defcustom org-html-klipse-js "https://storage.googleapis.com/app.klipse.tech/plugin_prod/js/klipse_plugin.min.js"
> +  "location of the klipse js source code."

Location of the klipse _javascript_ source code.

> +  :group 'org-export-html
> +  :type 'string)

See above.

> +(defcustom org-html-klipse-selection-script
> +  "window.klipse_settings = {selector_eval_html: '.src-html',
> +                             selector_eval_js: '.src-js',
> +                             selector_eval_python_client: '.src-python',
> +                             selector_eval_scheme: '.src-scheme',
> +                             selector: '.src-clojure',
> +                             selector_eval_ruby: '.src-ruby'};"
> +  "_javascript_ snippet to activate klipse"

_javascript_ snippet to activate klipse.

> +  :group 'org-export-html
> +  :type 'string)

See above.

> +   ;; klipse library for live code blocks, if requested
> +   (if org-html-klipsify-src

You shouldn't use `org-html-klipsify-src' directly in the code, but
instead "register" it in the back-end and call

  (plist-get info :html-klipsify-src)

See other defcustoms.

The new, attached patch hopefully addresses the above concerns. S

The new property also needs to be documented in "org.texi", in
Publishing directory.

I took a look at org.texi but my understanding of texi syntax is very poor and I don't think I have time to learn today. Bastien, would you be willing to take that on? Also, if you have thoughts on customizing the selection script I'd welcome them.

Yehonathan: can klipse_settings[selector] take multiple css classes, in case we need to be able to accommodate customizing it?
 

Regards,

--
Nicolas Goaziou


Attachment: 0001-Conform-to-Org-coding-standards-and-add-backwards-co.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]