emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [O] A small patch for org.el to fix error in clojure babel src block


From: address@hidden
Subject: Re: [O] A small patch for org.el to fix error in clojure babel src block code ref
Date: Tue, 9 May 2017 16:06:42 +0800

Weird, but this patch does fixed my issue. When I `org-store-link` in opened clojure babel src block will has this issue. But not in other languages babel src blocks like Python, Ruby, C etc.

[stardiviner]           <Hack this world!>      GPG key ID: 47C32433
IRC(freeenode): stardiviner                     Twitter:  @numbchild
Key fingerprint = 9BAA 92BC CDDD B9EF 3B36  CB99 B8C4 B8E5 47C3 2433
Blog: http://stardiviner.github.io/

On Tue, May 9, 2017 at 2:41 PM, Nicolas Goaziou <address@hidden> wrote:
Hello,

"address@hidden" <address@hidden> writes:

> Here is the original discussion we disscusses.
> https://github.com/jkitchin/org-ref/issues/433
>
> And Here is the patch:
>
> #+BEGIN_SRC diff
> modified   lisp/org.el
> @@ -9730,7 +9730,7 @@ active region."
>       (setq sfuns
>     (delq
>      nil (mapcar (lambda (f)
> -  (let (fs) (if (funcall f) (push f fs))))
> +  (let (fs) (if (and (stringp f) (funcall f)) (push f fs))))
>   (org-store-link-functions)))

The change above doesn't make sense, does it?

If F is a string, it cannot be funcall'ed. Since
`org-store-link-functions' only contains functions, this patch is
basically skipping the whole variable.

Regards,

--
Nicolas Goaziou


reply via email to

[Prev in Thread] Current Thread [Next in Thread]