emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [O] [PATCH] ox-html.el: Fix display of language indicators for sourc


From: Matt Price
Subject: Re: [O] [PATCH] ox-html.el: Fix display of language indicators for source blocks
Date: Mon, 12 Jun 2017 12:45:13 -0400

Hi,

You raise two important-seeming points about my patch:

1) a feature (display of language on hover) is removed by the patch
2) the patch also breaks XHTML validation

That patch was submitted to add support for live code examples in exported HTML (using the klipse.js  library).  As it stands right now, both changes (addition of `data-editor-type` attribute and moving the language name class from `pre` to `code`) are necessary to make klipse work (cf. https://github.com/viebel/klipse).  I'd rather not lose that functionality completely. Can you think of a way to solve both the problems without losing klipse funcitonality? If not, would you be satisfied with an improved docstring and maybe turning klipse off by default?


On Thu, Jun 8, 2017 at 3:42 PM, N. Raghavendra <address@hidden> wrote:
At 2017-06-08T21:24:31+02:00, Nicolas Goaziou wrote:

> I'm Cc'ing Matt Price, who introduced klipse feature, for some
> insight.

Thanks for the reply, and for the information.  I'll wait for Matt
Price's response.

> You posted the patch only two days ago. I hope you understand a "bump"
> may be a bit early at this point.

Certainly.  It was less a bump than an _expression_ of concern that my
messages may have been lost in the general mileu of the mailing list.

Cheers,
Raghu.

--
N. Raghavendra <address@hidden>, http://www.retrotexts.net/
Harish-Chandra Research Institute, http://www.hri.res.in/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]