[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [O] [PATCH] protocol: allow users to disable warning about old style
From: |
Nicolas Goaziou |
Subject: |
Re: [O] [PATCH] protocol: allow users to disable warning about old style links |
Date: |
Fri, 16 Jun 2017 08:13:25 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) |
Hello,
Alex Branham <address@hidden> writes:
> This patch allows org mode users to disable the warning issued about
>old org protocol style links. This is important because sometimes (e.g.
>browser extensions), we don’t have easy control over the format
>specified.
Thank you.
Wouldn't it be better to report it upstream as a bug? I don't think
there are many Org protocols applications out there and the conversion
to the new syntax is easy.
> Issuing the warning is annoying because it pops up in a new window.
I think this variable should go in "org-compat.el", so that we can
remove it when we drop old syntax. It also need
proper :version, :package-version and :safe keywords.
Another option is to make it a simple `defvar' and have the warning
message suggesting to set it.
WDYT?
> From 8bfc951308324de8e455128950193c046691f1f8 Mon Sep 17 00:00:00 2001
> From: Alex Branham <address@hidden>
> Date: Wed, 14 Jun 2017 14:06:18 +0200
> Subject: [PATCH] protocol: allow user to disable warning about old style links
>
> ---
> lisp/org-protocol.el | 11 +++++++++--
> 1 file changed, 9 insertions(+), 2 deletions(-)
>
> diff --git a/lisp/org-protocol.el b/lisp/org-protocol.el
> index 825435674..2eb1094e9 100644
> --- a/lisp/org-protocol.el
> +++ b/lisp/org-protocol.el
> @@ -271,6 +271,12 @@ This should be a single regexp string."
> :package-version '(Org . "8.0")
> :type 'string)
>
> +(defcustom org-protocol-warn-about-old-links t
> + "If non-nil (the default), issue a warning when org protocol
> +receives old style links."
When non-nil, warn when Org protocol receives old style link.
Regards,
--
Nicolas Goaziou
- [O] [PATCH] protocol: allow users to disable warning about old style links, Alex Branham, 2017/06/14
- Re: [O] [PATCH] protocol: allow users to disable warning about old style links,
Nicolas Goaziou <=
- Re: [O] [PATCH] protocol: allow users to disable warning about old style links, Alex Branham, 2017/06/16
- Re: [O] [PATCH] protocol: allow users to disable warning about old style links, Tyler Smith, 2017/06/21
- Re: [O] [PATCH] protocol: allow users to disable warning about old style links, Mario Martelli, 2017/06/21
- Re: [O] [PATCH] protocol: allow users to disable warning about old style links, Tyler Smith, 2017/06/21
- Re: [O] [PATCH] protocol: allow users to disable warning about old style links, Tyler Smith, 2017/06/21
- Re: [O] [PATCH] protocol: allow users to disable warning about old style links, Mario Martelli, 2017/06/21
- Re: [O] [PATCH] protocol: allow users to disable warning about old style links, Tyler Smith, 2017/06/21
- Re: [O] [PATCH] protocol: allow users to disable warning about old style links, Mario Martelli, 2017/06/21