[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [O] [PATCH] An amended to the enhance Org babel for scheme blocks
From: |
Nicolas Goaziou |
Subject: |
Re: [O] [PATCH] An amended to the enhance Org babel for scheme blocks |
Date: |
Mon, 24 Jul 2017 12:06:09 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) |
Hello,
"José L. Doménech" <address@hidden> writes:
> No, but I don't know what is the preferred format for the entries. So
> instead of a patch i send the complete entries.
OK.
> ***** Scheme: new function: ~org-babel-scheme-table-or-string~
>
> New helper function to convert the return value from the scheme block
> to a table or a string.
I think this can be kept as an internal function, and named
`org-babel-scheme--table-or-string'.
> * lisp/ob-scheme.el (org-babel-scheme-null-to): New custom option that
> allows to use a empty list or null symbol to format the table
> output, initially assigned to 'hlines.
* lisp/ob-scheme.el (org-babel-scheme-null-to): New variable.
is sufficient in this case.
> (org-babel-scheme-table-or-string): New helper function to convert
> the return value from the block to a table or a string.
Likewise: "New function."
> +(defun org-babel-scheme-table-or-string (results)
Per above, I suggest to name it `org-babel-scheme--table-or-string' and
update the code accordingly.
I made the changes suggested above and added a "TINYCHANGE" cookie at
the end of the commit message since I don't know I you signed the FSF
papers already. I you haven't, please consider doing it.
Thank you!
Regards,
--
Nicolas Goaziou