emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [O] point moves and zoom level reverts when refreshing agenda


From: Marco Wahl
Subject: Re: [O] point moves and zoom level reverts when refreshing agenda
Date: Sun, 24 Jun 2018 10:15:01 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux)

Bonjour!

Nicolas Goaziou <address@hidden> writes:

> Thank you. It looks good. Feel free to apply it.

Thanks, I did.

> I have two suggestions however:
>
> 1. There is some code duplication, e.g., (dolist ...), could this be
>    factored out before applying the patch?

Yes, done, thanks for the hint.  The patch has been committed.

> 2. Would it make sense to add the variables to preserve in a dedicated
>    top-level variable instead of burying them in the code?

I don't know.  Possibly this is a YAGNI.  A top-level variable could be
introduced any time.  Further someone might come up with a freshly
rewritten agenda in the meantime. ;)

BTW: It might be a good idea to take ideas from `list-buffers' and
friends for the rewrite of the agenda.


Ciao,
     Marco





reply via email to

[Prev in Thread] Current Thread [Next in Thread]