[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [O] [PATCH] Ensure org-get-tags includes all local tags

From: Matt Lundin
Subject: Re: [O] [PATCH] Ensure org-get-tags includes all local tags
Date: Wed, 25 Jul 2018 07:57:54 -0500
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)

>> With commit fbe56f89f75a8979e0ba48001a822518df2c66fe, the function
>> org-get-tags incorrectly removes uninherited tags from the list of tags
>> it returns, *even if* they are local tags.
>> Expected behavior: org-get-tags should always return local tags,
>> regardless of whether they are excluded from inheritance. The variable
>> org-tags-exclude-from-inheritance should only apply to tags in parent
>> heading or to file tags.
>> Actual behavior: if a local tag is in org-tags-exclude-from-inheritance,
>> org-get-tags will not return it.
>> I've attached a patch that fixes the issue.
> You're right. Thank you.
> Could you add a regression test for this and push the change?

Hi Nicolas,

Sorry for the delay. I finally had time to improve this fix (my first
fix caused another regression) and add a regression test. At the moment,
I don't have push rights to the Org Mode repo, so I'm attaching the
patch here.


Attachment: 0001-Ensure-that-org-get-tags-returns-all-local-tags.patch
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]