emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [O] [PATCH] Possible bug in org-protocol


From: Pierre Téchoueyres
Subject: Re: [O] [PATCH] Possible bug in org-protocol
Date: Sat, 09 Mar 2019 14:14:11 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.92 (gnu/linux)

Hello Nicolas,

Nicolas Goaziou <address@hidden> writes:

> Hello,
>
> address@hidden (Pierre Téchoueyres) writes:
>
>> I think so, as org-protocol, for what I've  understood, is triggered by
>> an URL where protocol is org-protocol. So the content of the URL itself
>> must be encoded.
>
> OK. I applied you fix. Thank you.

Thanks for your quick action. I've also written another test for
this patch.  Would you mind adding it too ?

As a bonus it show the manual paragraph explaining the neccessity to
encode the parts of url befor calling org-protocol.

diff --git a/testing/lisp/test-org-protocol.el 
b/testing/lisp/test-org-protocol.el
index fc764386c..6ee368dcf 100644
--- a/testing/lisp/test-org-protocol.el
+++ b/testing/lisp/test-org-protocol.el
@@ -35,6 +35,16 @@
   (let ((data (org-protocol-parse-parameters "url=abc&title=def" t)))
     (should (string= (plist-get data :url) "abc"))
     (should (string= (plist-get data :title) "def")))
+  ;; Parse new-style complex links
+  (let* ((url (concat "template=p&"
+                     
"url=https%3A%2F%2Forgmode.org%2Forg.html%23capture-protocol&"
+                     "title=The%20Org%20Manual&"
+                     "body=9.4.2%20capture%20protocol"))
+        (data (org-protocol-parse-parameters url)))
+    (should (string= (plist-get data :template) "p"))
+    (should (string= (plist-get data :url) 
"https://orgmode.org/org.html#capture-protocol";))
+    (should (string= (plist-get data :title) "The Org Manual"))
+    (should (string= (plist-get data :body) "9.4.2 capture protocol")))
   ;; Parse old-style links
   (let ((data (org-protocol-parse-parameters "abc/def" nil '(:url :title))))
     (should (string= (plist-get data :url) "abc"))
Regards,

P.S.
Is simple diffs an acceptable format for patches or should I send you an
fully formatted git commit ?

reply via email to

[Prev in Thread] Current Thread [Next in Thread]