[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [O] Suggested patch for org-agenda.el
|
From: |
Nicolas Goaziou |
|
Subject: |
Re: [O] Suggested patch for org-agenda.el |
|
Date: |
Wed, 08 May 2019 14:43:47 +0200 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) |
Hello,
Stefan Monnier <address@hidden> writes:
> Misc changes:
Thank you.
> - Assume Emacs≥22 (we're using defvaralias already anyway).
> - Try to make sure <foo>-function only contain functions (and never nil).
> - Use define-minor-mode and define-derived-mode.
> - Use command remapping.
> - Initialize map from within its definition.
> - Use suppress-keymap.
>
> There'd be more to do if we can assume ≥24.1, of course.
Starting from 9.0, Org assumes ≥24.4, so we can go wild, if necessary.
However, I cannot apply your patch on top of master branch. Would you
mind building your patch from Org repository?
Regards,
--
Nicolas Goaziou