Re: [O] [PATCH] org-clock-out overrides frame-title-format [9.2.3 (9.2.3-17-g4df705-elpa @ ~/.emacs.d/elpa/org-20190513/)]

[Nicolas Goaziou]

Hello,

Andrii Kolomoiets <address@hidden> writes:

> The org-frame-title-format-backup variable is initialized on
> org-clock.el loading and future changes to frame-title-format is
> ignored:
>
> 1. emacs -Q
> 2. M-: frame-title-format
>    It's "%b"
> 3. M-: (require 'org-clock)
> 4. (setq frame-title-format "%b bar")
> 5. C-x b test.org
> 6. M-x org-mode
> 7. Insert heading (M-RET foo)
> 8. M-x org-clock-in
> 9. M-x org-clock-out
> 10. M-: frame-title-format
>     It's "%b" again
>     
> With provided patch org-frame-title-format-backup is initialized on
> org-clock-in. Also frame-title-format is restored to
> org-frame-title-format-backup only if current frame-title-format is
> equal to org-clock-frame-title-format in case frame title format is
> changed after org-clock-in.

Thank you.

I think this could be factored out a bit, for example creating a simple
function taking care of updating `frame-title-format' if needed.

Also, could you provide a proper commit message and use git format-patch
to send it again?

Regards,

-- 
Nicolas Goaziou