[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [O] [PATCH] ox-html: add option to restore old src block behaviour?
From: |
Nicolas Goaziou |
Subject: |
Re: [O] [PATCH] ox-html: add option to restore old src block behaviour? |
Date: |
Tue, 08 Oct 2019 11:31:41 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) |
Hello,
Jens Lechtenboerger <address@hidden> writes:
> The attached patch adds a new variable org-html-wrap-src-lines to
> control whether code tags should be added or not.
Thank you.
However, the patch is not right. Exporters do not use defcustoms
directly. Instead, you register them within :options-alist in the the
back-end definition, e.g., under :html-wrap-src-lines and then call
(plist-get info :html-wrap-src-lines) in the function. This allows to
control these options during publishing.
Also, this would need an entry in the manual, if only in the "options
for the exporters" subsection.
> I’m not sure whether :package-version 9.3 is correct.
It is correct. You can also use :safe t.
> Also, I set the value to t, which does not change the current
> functionality. However, for backwards compatibility (up to version
> 9.2.6), a value of nil would be preferable. Any thoughts?
I agree with the nil default value.
> +(defcustom org-html-wrap-src-lines t
> + "If t, wrap individual lines of source blocks in \"code\" elements.
When non-nil, wrap...
Regards,
--
Nicolas Goaziou