[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Fix ob-python.el initiate session error with py-shell
From: |
Jack Kamm |
Subject: |
Re: [PATCH] Fix ob-python.el initiate session error with py-shell |
Date: |
Wed, 19 Feb 2020 07:51:24 -0800 |
Hi stardiviner,
"address@hidden" <address@hidden> writes:
> Yes, Jack, as Bastien said, you can format my commit, because my home
> network is broken, I'm using Mobile Phone's 4G network to get online. Can't
> get update immediately.
OK, I've edited the commit message of your patch, and I also fixed the
compilation warning by updating the signature of "(declare-function
py-shell)".
Commit has now been pushed to master :)
> And thanks for tips about `python-mode' is deprecated. I didn't know that.
> I will migrate to `python.el'.
Since python.el is built-in to Emacs, I think that things should
continue to work for python-mode.el users, even if we entirely switch
over to only using python.el.
The only thing I'm not sure about, is whether the equivalent of
"python-shell-send-region" in python-mode.el will work with shells
started by python.el. If not, this could probably be addressed with a
patch to python-mode.el.
You could test this by explicitly setting `org-babel-python-mode' to
`python' (it is probably set to `python-mode' on your system, which is
the default when python-mode.el is detected).
I'll add a TODO for myself to explicitly mark python-mode-related
variables as deprecated. I'm also planning a major update to the Worg
documentation of ob-python when 9.4 comes out, and will mention the
deprecation there as well.
- [PATCH] Fix ob-python.el initiate session error with py-shell, stardiviner, 2020/02/18
- Re: [PATCH] Fix ob-python.el initiate session error with py-shell, Bastien, 2020/02/18
- Re: [PATCH] Fix ob-python.el initiate session error with py-shell, Jack Kamm, 2020/02/18
- Re: [PATCH] Fix ob-python.el initiate session error with py-shell, Jack Kamm, 2020/02/18
- Re: [PATCH] Fix ob-python.el initiate session error with py-shell, Bastien, 2020/02/18
- Re: [PATCH] Fix ob-python.el initiate session error with py-shell, address@hidden, 2020/02/19
- Re: [PATCH] Fix ob-python.el initiate session error with py-shell,
Jack Kamm <=
- Re: [PATCH] Fix ob-python.el initiate session error with py-shell, Bastien, 2020/02/19
- Re: [PATCH] Fix ob-python.el initiate session error with py-shell, stardiviner, 2020/02/20
- Re: [PATCH] Fix ob-python.el initiate session error with py-shell, Andreas Röhler, 2020/02/20
- Re: [PATCH] Fix ob-python.el initiate session error with py-shell, Bastien, 2020/02/20
- Re: [PATCH] Fix ob-python.el initiate session error with py-shell, Jack Kamm, 2020/02/20
- Re: [PATCH] Fix ob-python.el initiate session error with py-shell, Bastien, 2020/02/20
- Re: [PATCH] Fix ob-python.el initiate session error with py-shell, stardiviner, 2020/02/22