emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Document backward-incompatible change in ORG-NEWS?


From: Bastien
Subject: Re: Document backward-incompatible change in ORG-NEWS?
Date: Tue, 25 Feb 2020 20:34:51 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)

Hi Nicolas,

Nicolas Goaziou <address@hidden> writes:

> You are right. This deserves an entry in ORG-NEWS.

thanks for your feedback, I've added this entry:
https://code.orgmode.org/bzg/org-mode/commit/1a84a8b611

> I think this is inefficient. It would be better to search directly for
>
>   (format "\\[\\[\\*%s\\s-+" (regexp-opt org-todo-keywords-1 t))

Indeed... I've pushed a simpler version, feel free to enhance it.

>>        (setq new (replace-regexp-in-string
>>                   (concat (regexp-opt org-todo-keywords-1) "\\s-+")
>>                   "" raw))
>>        (set-text-properties 0 (length new) nil new)
>
> Why do you remove all text properties? Also, see `org-no-properties'.

For the record, it seems that completing-read fifth argument cannot
be a string with properties - at least from the quick test I did.

Thanks,

-- 
 Bastien



reply via email to

[Prev in Thread] Current Thread [Next in Thread]