[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Do not ignore org-odt-styles-file
From: |
Kyle Meyer |
Subject: |
Re: [PATCH] Do not ignore org-odt-styles-file |
Date: |
Fri, 06 Mar 2020 04:28:22 +0000 |
Thanks for the patch.
Eric Timmons <address@hidden> writes:
> :odt-styles-file was duplicated in ox-odt's org-export-define-backend
> form. This lead to the org-odt-styles-file custom being completely ignored.
That change looks good, and, while I'm not an ox-odt user, light testing
on my end confirms the issue and fix.
Could you update your patch to follow the conventions outlined at
<https://orgmode.org/worg/org-contribute.html>? In particular, add (1)
a change-log entry to the commit message and (2) a TINYCHANGE cookie.
Also, it's typical for commit subjects in this project to start with
"<area or file>: ...".