Re: [SOLVED] Re: [PATCH] Show hidden drawers when org-cycle on headlines

[stardiviner]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256


Nicolas Goaziou <address@hidden> writes:

> Hello,
>
> Ihor Radchenko <address@hidden> writes:
>
>>> Thanks Ihor, I indeed found related code in Org Mode source. I implemented a
>>> similar functionality in my patch.
>>
>> Oh. I somehow missed your first message...
>>
>> Now, actually adding something to the discussion.
>>
>> FYI, there is org-cycle-include-plain-lists variable. If it is set to
>> 'integrate, plain lists will be included into cycling with point at
>> headline. This is against the logic that org-cycle only needs to be
>> dealing with headlines. So, I don't see your patch breaking the present
>> conventions in org.
>
> Yes, this `integrate' value is not great, IMO. However, plain lists have
> much more in common with headlines than with drawers.
>
> I still think basic cycling should not include drawers whatsoever. This
> is even more true for properties drawers.
>
> Note that you can already display drawers with `org-cycle', using three
> prefix arguments.

I agree. As I described in my given example "org-contacts", which include person
info in properties drawer. That's why I want to expand when I press "Tab" on
expanding headline. If I see a contact's info with "C-u C-u C-u Tab" is not
convenient.

As for this negation, I can accept.

Is it possible to change "org-cycle-hide-drawers" to "org-cycle-toggle-drawers".
Make it more extendable. Because that function only changed one argument of
"org-flag-drawer". If so some user like me will be easy to toggle hide/show
drawers. (Of course, I don't want to add redundant code in my Emacs init.) If
this is fine, I will re-edit my patch. Remove defcustom option, and hook on
cycle. Only keep changes in "org-cycle-hide-drawers".

- -- 
[ stardiviner ]
       I try to make every word tell the meaning what I want to express.

       Blog: https://stardiviner.github.io/
       IRC(freenode): stardiviner, Matrix: stardiviner
       GPG: F09F650D7D674819892591401B5DF1C95AE89AC3
      
-----BEGIN PGP SIGNATURE-----

iQFIBAEBCAAyFiEE8J9lDX1nSBmJJZFAG13xyVromsMFAl6VSEgUHG51bWJjaGls
ZEBnbWFpbC5jb20ACgkQG13xyVromsMFWAgAlhqnLF0PByf0k2Au3v7Ge4kj+BeF
U/S0XL+U3t8sjGSvXpR50AFEH9wPsp2Hr0yguJ2/WJDYDAO8dvzphcMgwP/q5EfZ
25hmKWQOP25rBMiHyXVcws6lVWLcsZ55l9k5ff/3mR2j5qV5dsA37G4gosbfTwMn
a29FXHyLBxMZMZgKGfK3cDY+W7F0tZ+XO4+E6TTZzu6OD8EmUwptbkmBd5XyiomQ
C7R1lBSR2xOYxFgdqy9sEp88lcRufN0tK3dun0hIotfabGq2HVv7lvsfD9DOC+IF
jaJKBzVzIAfvFCJVIUksW+DKvB4CiwL/Wm3NbzRaQmM4XZ66Emn1CaPYjQ==
=xMZt
-----END PGP SIGNATURE-----