emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2] Re: [BUG] recently commits on master branch breaks comman


From: Matthew Lundin
Subject: Re: [PATCH v2] Re: [BUG] recently commits on master branch breaks command 'org-babel-demarcate-block'
Date: Sun, 31 May 2020 20:12:23 -0500

stardiviner <numbchild@gmail.com> writes:

> Matthew Lundin <mdl@imapmail.org> writes:
>
>>
>> I think you also need to replace the newline with a space in the upper
>> case version.
>>
> Supposed there is \n after #+end_src. I also checked the original version 
> before
> that change commit. The original has an newline. I write patch by comparing
> before and after (side by side).

I'm referring to this line in the patch:

                        indent (if upper-case-p "#+BEGIN_SRC\n" "#+begin_src ")
                                                             ^

The newline that needs to be removed is indicated by "^".

You can see a correct similar version of this line on line 1932 of
ob-core.el.

The original line the problematic commit replaced would also have had a
space in both, since it called either downcase or upcase on the string
"#+begin_src ".

Best,

Matt



reply via email to

[Prev in Thread] Current Thread [Next in Thread]