[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] New function org-agenda-filter-set
From: |
Kyle Meyer |
Subject: |
Re: [PATCH] New function org-agenda-filter-set |
Date: |
Fri, 05 Jun 2020 03:58:05 +0000 |
Bastien writes:
> I've seen problems with this new function when completing in agendas:
> hitting '/' does not see what tags are available for completion in the
> current buffer.
>
> I'm reverting e9b1b8fde5 from master for now. If you see what's wrong,
> please resubmit a patch.
Stepping through both versions, it looks like the crucial thing is that
org-agenda-get-represented-tags needs to be called _before_ the
completion function. If it's not, org-agenda-filter-completion-function
calls -get-represented-tags with an unset cache, and it returns nil
because the (derived-mode-p 'org-agenda-mode) condition is nil.
The same goes for org-agenda-get-represented-categories.