[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Patch: send 'return' after babel blocks sent to ob-screen [9.3.7 (9.
From: |
Kyle Meyer |
Subject: |
Re: Patch: send 'return' after babel blocks sent to ob-screen [9.3.7 (9.3.7-12-g5d6868-elpaplus @ /home/kdm/.emacs.d/elpa/org-plus-contrib-20200706/)] |
Date: |
Tue, 14 Jul 2020 00:55:12 -0400 |
Ken Mankoff writes:
> Using ob-screen and this example:
>
> #+begin_src screen
> ls
> #+end_src
>
> The "ls" is transmitted to the screen session, but without a newline,
> it does not execute.
I see that on my end too. I've never used ob-screen, and, with this
sort of issue, the same might be true for nearly everybody, assuming
this wasn't a recent regression. (I don't spot any obvious culprits.)
> The following patch adds a newline to all babel blocks sent to the screen
> session.
>
> diff --git a/lisp/ob-screen.el b/lisp/ob-screen.el
> index 75a2dc691..5616143fe 100644
> --- a/lisp/ob-screen.el
> +++ b/lisp/ob-screen.el
> @@ -108,7 +108,7 @@ In case you want to use a different screen than one
> selected by your $PATH")
> (let ((tmpfile (org-babel-temp-file "screen-")))
> (with-temp-file tmpfile
> (insert body)
> -
> + (insert "\n")
> ;; org-babel has superfluous spaces
> (goto-char (point-min))
> (delete-matching-lines "^ +$"))
Thanks. Looks good and seems to work on my end. Could prepare that as
a patch with a commit message (details at
https://orgmode.org/worg/org-contribute.html)?
- Patch: send 'return' after babel blocks sent to ob-screen [9.3.7 (9.3.7-12-g5d6868-elpaplus @ /home/kdm/.emacs.d/elpa/org-plus-contrib-20200706/)], Ken Mankoff, 2020/07/09
- Re: Patch: send 'return' after babel blocks sent to ob-screen [9.3.7 (9.3.7-12-g5d6868-elpaplus @ /home/kdm/.emacs.d/elpa/org-plus-contrib-20200706/)],
Kyle Meyer <=
- [PATCH] 3 improvements to ob-screen, Ken Mankoff, 2020/07/14
- Re: [PATCH] 3 improvements to ob-screen, Kyle Meyer, 2020/07/14
- Re: [PATCH] 3 improvements to ob-screen, Ken Mankoff, 2020/07/15
- Re: [PATCH] 3 improvements to ob-screen, Kyle Meyer, 2020/07/15
- Re: [PATCH] 3 improvements to ob-screen, Kyle Meyer, 2020/07/15
- Re: [PATCH] 3 improvements to ob-screen, Ken Mankoff, 2020/07/16