Bug: [patch] Fix org-babel-result-to-file never expanding links when babel is evaluated in indirect buffer [9.3.7 (release_9.3.7-728-g1efc4e @ /home/yantar92/.emacs.d/straight/build/org/)]

[Ihor Radchenko]

Remember to cover the basics, that is, what you expected to happen and
what in fact did happen.  You don't know how to make a good report?  See

     https://orgmode.org/manual/Feedback.html#Feedback

Your bug report will be posted to the Org mailing list.
------------------------------------------------------------------------

I noticed that org-babel-result-to-file never expands file: links in
src block results when ran from indirect buffer and default-directory
is not same with base buffer file's directory. This is against the
docstring stating that

> If the `default-directory' is different from the containing
> file's directory then expand relative links.

The misbehavior happens because buffer-file-name variable is always
nil in indirect buffers. We need to call (file-name-directory
(buffer-file-name (buffer-base-buffer))) instead.

The patch is attached.

Best,
Ihor

diff --git a/lisp/ob-core.el b/lisp/ob-core.el
index f86282f0f..d37eef5f9 100644
--- a/lisp/ob-core.el
+++ b/lisp/ob-core.el
@@ -2561,16 +2561,16 @@ If the `default-directory' is different from the 
containing
 file's directory then expand relative links."
   (when (stringp result)
     (let ((same-directory?
-          (and buffer-file-name
+          (and (buffer-file-name (buffer-base-buffer))
                (not (string= (expand-file-name default-directory)
-                             (expand-file-name
-                              (file-name-directory buffer-file-name)))))))
+                           (expand-file-name
+                            (file-name-directory (buffer-file-name 
(buffer-base-buffer)))))))))
       (format "[[file:%s]%s]"
-             (if (and default-directory buffer-file-name same-directory?)
+             (if (and default-directory (buffer-file-name 
(buffer-base-buffer)) same-directory?)
                  (if (eq org-link-file-path-type 'adaptive)
                      (file-relative-name
                       (expand-file-name result default-directory)
-                      (file-name-directory (buffer-file-name)))
+                      (file-name-directory (buffer-file-name 
(buffer-base-buffer))))
                    (expand-file-name result default-directory))
                result)
              (if description (concat "[" description "]") "")))))

Emacs  : GNU Emacs 28.0.50 (build 4, x86_64-pc-linux-gnu, GTK+ Version 3.24.20, 
cairo version 1.16.0)
 of 2020-07-27
Package: Org mode version 9.3.7 (release_9.3.7-728-g1efc4e @ 
/home/yantar92/.emacs.d/straight/build/org/)

-- 
Ihor Radchenko,
PhD,
Center for Advancing Materials Performance from the Nanoscale (CAMP-nano)
State Key Laboratory for Mechanical Behavior of Materials, Xi'an Jiaotong 
University, Xi'an, China
Email: yantar92@gmail.com, ihor_radchenko@alumni.sutd.edu.sg