emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] org-capture: Update plist before finalizing


From: Leo Vivier
Subject: Re: [PATCH] org-capture: Update plist before finalizing
Date: Sat, 05 Sep 2020 09:11:27 +0200

Hi there,

Kyle Meyer <kyle@kyleam.com> writes:

> Thanks for the detailed write-up and the patch (and sorry for the slow
> reply).

No worries, and thanks for the review.

> It'd be good to at least point to the motivation/usecase for this change
> here.  (Your description section above already does a nice job of
> that.)

Done.  I’ve also added a link to this thread.

> Convention nit: please end your comment with a period.

Done.

> Perhaps add a brief mention of `org-capture-after-finalize' (or some
> other hint of why) here.

I’ve added some details to bridge the gap with the docstring for
`org-capture-current-plist'.

You’ll find the amended commit below.

Best,

-- 
Leo Vivier
Freelance Software Engineer
Website: www.leovivier.com | Blog: www.zaeph.net

Attachment: 0001-org-capture-Update-plist-before-finalizing.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]