Re: [patch suggestion] Mitigating the poor Emacs performance on huge org files: Do not use overlays for PROPERTY and LOGBOOK drawers

[Ihor Radchenko]

>> then M-x toggle-debug-on-error and M-: (org-make-manuals), but I can't
>> get a stacktrace.  I'm guessing this is because this error (which IIUC
>> originates from org-back-to-heading in org.el) is a user-error; however,
>> if I change the function to raise a "regular error", then everything
>> compiles fine… 😕
>
> I suspect that you forgot to run =make clean= (to remove old untracked
> .elc files).

I was wrong. It was actually a problem with org-back-to-heading. Should
be fixed now.

Best,
Ihor

Ihor Radchenko <yantar92@gmail.com> writes:

>>     I get a conflict in org.el, on the hunk where org-reveal-location
>>     and org-show-context-detail are defined; since your patch just
>>     deletes them, I resolve this with:
>
> That's because the patch was against 0afef17e1. The new version of the
> patch (same URL) is against aea1109ef now.
>
>> I've tried going to doc/, running 
>>
>>     emacs -Q --eval '(setq vc-handled-backends nil org-startup-folded nil)' \
>>       --eval '(add-to-list '"'"'load-path "../lisp")' \
>>       --eval '(load "../mk/org-fixup.el")'
>>
>> then M-x toggle-debug-on-error and M-: (org-make-manuals), but I can't
>> get a stacktrace.  I'm guessing this is because this error (which IIUC
>> originates from org-back-to-heading in org.el) is a user-error; however,
>> if I change the function to raise a "regular error", then everything
>> compiles fine… 😕
>
> I suspect that you forgot to run =make clean= (to remove old untracked
> .elc files).
>
> Best,
> Ihor
>
> Kévin Le Gouguec <kevin.legouguec@gmail.com> writes:
>
>> Hi!
>>
>> Ihor Radchenko <yantar92@gmail.com> writes:
>>
>>> The current version of the patch (against master) is in
>>> https://gist.github.com/yantar92/6447754415457927293acda43a7fcaef
>>
>> I'm probably missing something obvious, but when applying your patch on
>> top of master[1], make fails when generating manuals:
>>
>>> emacs  -Q -batch --eval '(setq vc-handled-backends nil org-startup-folded 
>>> nil)' \
>>>   --eval '(add-to-list '"'"'load-path "../lisp")' \
>>>   --eval '(load "../mk/org-fixup.el")' \
>>>   --eval '(org-make-manuals)'
>>> Loading 
>>> /home/peniblec/Downloads/sources/emacs-meta/org-mode/mk/org-fixup.el 
>>> (source)...
>>> Before first headline at position 760959 in buffer org-manual.org<2>
>>> make[1]: *** [Makefile:31: org.texi] Error 255
>>
>> I've tried going to doc/, running 
>>
>>     emacs -Q --eval '(setq vc-handled-backends nil org-startup-folded nil)' \
>>       --eval '(add-to-list '"'"'load-path "../lisp")' \
>>       --eval '(load "../mk/org-fixup.el")'
>>
>> then M-x toggle-debug-on-error and M-: (org-make-manuals), but I can't
>> get a stacktrace.  I'm guessing this is because this error (which IIUC
>> originates from org-back-to-heading in org.el) is a user-error; however,
>> if I change the function to raise a "regular error", then everything
>> compiles fine… 😕
>>
>>
>> [1] git apply --3way, on top of commit b64ba64fe.
>>
>>     I get a conflict in org.el, on the hunk where org-reveal-location
>>     and org-show-context-detail are defined; since your patch just
>>     deletes them, I resolve this with:
>>
>>     git checkout --theirs -- lisp/org.el