[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH] Re: Any reason not to generate my own custom ID value (NOT CUSTO
From: |
Ihor Radchenko |
Subject: |
[PATCH] Re: Any reason not to generate my own custom ID value (NOT CUSTOM_ID)? |
Date: |
Wed, 23 Sep 2020 15:43:05 +0800 |
See the attached.
>From bc492bd2fb87912289c135006b6fbeaca93ba181 Mon Sep 17 00:00:00 2001
From: Ihor Radchenko <yantar92@gmail.com>
Date: Fri, 11 Sep 2020 15:42:53 +0800
Subject: [PATCH] Allow customised ID format for `ts' `org-id-method'
* lisp/org-id.el (org-id-new): Use `org-id-ts-format' as ID format for
`ts' ID generation method.
(org-id-ts-format): New custom variable for `ts' ID format. The
default value is the same as old hard-coded ID format string.
---
lisp/org-id.el | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/lisp/org-id.el b/lisp/org-id.el
index f8af52964..512703269 100644
--- a/lisp/org-id.el
+++ b/lisp/org-id.el
@@ -128,6 +128,10 @@ nil Never use an ID to make a link, instead link using a
text search for
:group 'org-id
:type 'string)
+(defcustom org-id-ts-format "%Y%m%dT%H%M%S.%6N"
+ "Default format for IDs generated using `ts' `org-id-method'.
+The format should be suitable to pass as an argument to `format-time-string'.")
+
(defcustom org-id-method 'uuid
"The method that should be used to create new IDs.
@@ -380,7 +384,7 @@ So a typical ID could look like \"Org:4nd91V40HI\"."
(concat "@" (message-make-fqdn))))))
(setq unique (concat etime postfix))))
((eq org-id-method 'ts)
- (let ((ts (format-time-string "%Y%m%dT%H%M%S.%6N"))
+ (let ((ts (format-time-string org-id-ts-format))
(postfix (if org-id-include-domain
(progn
(require 'message)
--
2.26.2
Bastien <bzg@gnu.org> writes:
> Hi Ihor,
>
> Ihor Radchenko <yantar92@gmail.com> writes:
>
>>> However, I just (strongly) prefer the shorter "ISO-like" ID for many
>>> reasons, as already mentioned (shorter, meaningful, etc.). I just find
>>> that style much, much more elegant.
>>
>> I guess it does not take much to add this functionality.
>>
>> Patch attached.
>
> Thanks. Can you update the patch with a correct Changelog entry and a
> note to etc/ORG-NEWS announcing the new option?
>
> See https://orgmode.org/worg/org-contribute.html#commit-messages if it
> helps.
>
> --
> Bastien
- Re: Any reason not to generate my own custom ID value (NOT CUSTOM_ID)?, (continued)
- Re: Any reason not to generate my own custom ID value (NOT CUSTOM_ID)?, Gustav Wikström, 2020/09/10
- Re: Any reason not to generate my own custom ID value (NOT CUSTOM_ID)?, Samuel Wales, 2020/09/10
- Re: Any reason not to generate my own custom ID value (NOT CUSTOM_ID)?, TRS-80, 2020/09/10
- Re: Any reason not to generate my own custom ID value (NOT CUSTOM_ID)?, Ihor Radchenko, 2020/09/10
- Re: Any reason not to generate my own custom ID value (NOT CUSTOM_ID)?, TRS-80, 2020/09/10
- Re: Any reason not to generate my own custom ID value (NOT CUSTOM_ID)?, Ihor Radchenko, 2020/09/11
- Re: Any reason not to generate my own custom ID value (NOT CUSTOM_ID)?, Bastien, 2020/09/13
- Re: Any reason not to generate my own custom ID value (NOT CUSTOM_ID)?, Bastien, 2020/09/23
- [PATCH] Re: Any reason not to generate my own custom ID value (NOT CUSTOM_ID)?,
Ihor Radchenko <=
- Re: [PATCH] Re: Any reason not to generate my own custom ID value (NOT CUSTOM_ID)?, Bastien, 2020/09/23
- Re: [PATCH] Re: Any reason not to generate my own custom ID value (NOT CUSTOM_ID)?, Ihor Radchenko, 2020/09/23
- Re: [PATCH] Re: Any reason not to generate my own custom ID value (NOT CUSTOM_ID)?, Bastien, 2020/09/23
- Re: [PATCH] Re: Any reason not to generate my own custom ID value (NOT CUSTOM_ID)?, Ihor Radchenko, 2020/09/23
- Re: [PATCH] Re: Any reason not to generate my own custom ID value (NOT CUSTOM_ID)?, Bastien, 2020/09/23