Bug: Incorrect done TODO keywords highlighting in column view

[Martin Kampas]

Hi,

In columns view, all TODO keywords except those with face set explicitly with org-todo-keyword-faces are red. Done keywords should be green.

Patch below.

BR,

Martin

From a4df0da1057afbe90ea0e457158082b15386a164 Mon Sep 17 00:00:00 2001

From: Martin Kampas <martin.kampas@ubedi.net>

Date: Fri, 9 Oct 2020 07:43:17 +0200

Subject: [PATCH] org-colview: Fix done TODO keywords highlighting

* lisp/org-colview.el (org-columns--overlay-text): Populate

org-done-keywords from org-done-keywords-for-agenda or the done keywords

will use the same face as not-done keywords.

---

 lisp/org-colview.el | 4 +++-

 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/lisp/org-colview.el b/lisp/org-colview.el

index e50a4d7c8..827f57e5e 100644

--- a/lisp/org-colview.el

+++ b/lisp/org-colview.el

@@ -365,7 +365,9 @@ ORIGINAL is the real string, i.e., before it is modified by

                   org-tags-special-faces-re

                   (lambda (m) (propertize m 'face (org-get-tag-face m)))

                   v nil nil 1)))

-              ("TODO" (propertize v 'face (org-get-todo-face original)))

+              ("TODO"

+               (let ((org-done-keywords org-done-keywords-for-agenda))

+                 (propertize v 'face (org-get-todo-face original))))

               (_ v)))))

 

 (defvar org-columns-header-line-remap nil

--

2.28.0