emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Bug fix attached: org-babel sql postgres, fix hardcode


From: Tom Gillespie
Subject: Re: Bug fix attached: org-babel sql postgres, fix hardcode
Date: Sat, 12 Dec 2020 21:11:37 -0500

It looks like the two patches are sequential, there should probably be
a rebase into a single patch. I would remove the comment in the second
patch because it is a single command to jump to the default value and
it might change in the future, so no reason to put it in a comment.
One way to communicate about the source of that variable is to include
(require 'sql) in ob-sql which is likely needed anyway due to the fact
that sql-postgres-program is defined by sql.el and there will be a
byte compiler error because the variable is undefined. Having the
value of "psql" present as a backup in case sql-postgres-program is
somehow nil seems reasonable. Best,
Tom



reply via email to

[Prev in Thread] Current Thread [Next in Thread]