[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] org-contacts.el: Only use org-id-store-link if org-id is loa
From: |
miles christopher |
Subject: |
Re: [PATCH] org-contacts.el: Only use org-id-store-link if org-id is loaded |
Date: |
Mon, 4 Jan 2021 03:44:57 +0000 |
Thanks for your patch. :smile:
Can you send patch file as attachment? I don't know how to apply patch in email
body.
David Florness <david@florness.com> writes:
> Fixes bug introduced in 6b83c6e4e that made org-contacts-anniversaries
> error if org-id was not loaded.
> ---
> Alternatively, we could autoload org-id-link-to-org-use-id. If you all
> would prefer this, let me know and I can send a v2 patch.
>
> 6b83c6e4e was found using git-blame.
>
> contrib/lisp/org-contacts.el | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/contrib/lisp/org-contacts.el b/contrib/lisp/org-contacts.el
> index 82881ecd0..7ad425519 100644
> --- a/contrib/lisp/org-contacts.el
> +++ b/contrib/lisp/org-contacts.el
> @@ -1166,7 +1166,7 @@ are effectively trimmed). If nil, all zero-length
> substrings are retained."
> "Store the contact in `org-contacts-files' with a link."
> (when (and (eq major-mode 'org-mode)
> (member (buffer-file-name) (mapcar 'expand-file-name
> org-contacts-files)))
> - (if org-id-link-to-org-use-id
> + (if (and (featurep 'org-id) org-id-link-to-org-use-id)
> (org-id-store-link)
> (let ((headline-str (substring-no-properties (org-get-heading t t t
> t))))
> (org-store-link-props
--
[ stardiviner ]
I try to make every word tell the meaning that I want to express.
Blog: https://stardiviner.github.io/
IRC(freenode): stardiviner, Matrix: stardiviner
GPG: F09F650D7D674819892591401B5DF1C95AE89AC3
[PATCH v2] org-contacts.el: Only use org-id-store-link if org-id is loaded, David Florness, 2021/01/04