emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] ob-java, a proposal on import improvement


From: John Herrlin
Subject: Re: [PATCH] ob-java, a proposal on import improvement
Date: Sun, 10 Jan 2021 21:55:47 +0100
User-agent: mu4e 1.4.13; emacs 27.1

ian martins <ianxm@jhu.edu> writes:

> On Fri, Jan 8, 2021 at 11:28 AM John Herrlin <jherrlin@gmail.com> wrote:
>
>> I would like to combine imports from header-args with imports from a
>> source block.
>> ...
>> I didnt get the to work so I made a patch.
>
> John, Sorry that wasn't working. Thanks for investigating and
> submitting a fix.  I think the problem was that I was missing static
> imports, which you fixed in the first chunk of your patch. I don't
> think the rest of the change is necessary. Could you revert the other
> chunks and re-test?

Thats looks correct! Thanks!

Here is a patch with the regexp fix.

Take care!

Attachment: 0001-ob-java-Include-static-imports-in-regex.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]