|
From: | TRS-80 |
Subject: | Re: [PATCH] org-footnote: fix inserting new footnote mangling drawers (was: Re: Bug: inserting footnote when Footnotes heading has property drawer [9.3.6 (9.3.6-23-g01ee25-elpaplus @ /home/user/.emacs.d/elpa/org-plus-contrib-20200309/)]) |
Date: | Tue, 12 Jan 2021 14:46:14 -0500 |
User-agent: | Roundcube Webmail/1.3.15 |
On 2021-01-10 19:57, Kyle Meyer wrote:
Thanks for the initial report and the patch.
I am very happy to contribute! Thanks for taking it easy on me the first time around. :)
TRS-80 writes:Subject: [PATCH] org-footnote: fix inserting new footnote mangling drawersconvention nit: s/fix/Fix/ (no need to resend)
Duly noted!
I'm planning to squash the following test in when applying. Look okay to you? diff --git a/testing/lisp/test-org-footnote.el b/testing/lisp/test-org-footnote.el index eca24d315..50a430785 100644 --- a/testing/lisp/test-org-footnote.el +++ b/testing/lisp/test-org-footnote.el @@ -138,7 +138,20 @@ (ert-deftest test-org-footnote/new () (org-test-with-temp-text "Paragraph<point>\n# Local Variables:\n# foo: t\n# End:" (let ((org-footnote-section "Footnotes")) (org-footnote-new)) - (buffer-string))))) + (buffer-string)))) + (should + (equal "Para[fn:1] +* Footnotes +:properties: +:custom_id: id +:end: + +\[fn:1]" + (org-test-with-temp-text+ "Para<point>\n* Footnotes\n:properties:\n:custom_id: id\n:end:"+ (let ((org-footnote-section "Footnotes")) + (org-footnote-new)) + (org-trim (buffer-string)))))) (ert-deftest test-org-footnote/delete () "Test `org-footnote-delete' specifications."
I must admit that currently I am still unfamiliar with the testing framework(s). It is something I am interested in learning, but haven't gotten around to /yet/. Therefore, hopefully some other set of eyeballs could give that another look? Cheers, TRS-80
[Prev in Thread] | Current Thread | [Next in Thread] |