Hi,
thank you very much for you feedback.
Kyle Meyer <
kyle@kyleam.com> wrote:
>> This patch is large enough that copyright should be assigned to the FSF.
>> Assuming you haven't already, are you willing to complete the copyright
>> paperwork?
I did this before sending the patch.
>> It looks like many of the lines are corrupted by additional line breaks,
>> so it'd take a lot of manual editing to resolve the issues on my end.
I addressed your points and added the patch as an attachment to avoid potential
issues.
>>>> + (mapconcat #'identity
>>>> + (delq nil
>>>> + (list (when (and host port) (format "-n %s:%s" host
>>>> port))
>> Please prefer `and' here and in other spots where the return value is of
>> interest.
>> (and host port (format ...))
I used `when' for consistency, as all the other methods are using it, but I
don't mind changing it to `and'.
0001-ob-sql.el-Add-support-for-SAP-HANA.patch