emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Bug: [PATCH] define-minor-mode: prefer keyword args [9.4.5 (9.4.5-ga


From: Bastien
Subject: Re: Bug: [PATCH] define-minor-mode: prefer keyword args [9.4.5 (9.4.5-ga02a3b @ /home/n/.emacs.d/straight/build/org-plus-contrib/)]
Date: Mon, 26 Apr 2021 14:51:36 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)

Hi,

thanks for the patch, we do indeed need to move forward for this.

Could you propose the patch against the master branch (not the maint
branch, since this is not a bugfix) and perhaps fix *all* warnings?

Also, here the preferred format for the commit message:

* lisp/org-table.el (org-table-header-line-mode)
(org-table-follow-field-mode): Migrate minor mode
definitions from positional arguments to keyword args.

* lisp/org-src.el (org-src-mode): Ditto.

* lisp/org-list.el (org-list-checkbox-radio-mode): Ditto.

Don't worry too much about it, I can always rearrange it.

Thanks!



reply via email to

[Prev in Thread] Current Thread [Next in Thread]