[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Bug: [patch] fix: ox-rss died when an entry had an empty date [ ( @
From: |
Bastien |
Subject: |
Re: Bug: [patch] fix: ox-rss died when an entry had an empty date [ ( @ /home/arne/.guix-profile/share/emacs/site-lisp/)] |
Date: |
Fri, 30 Apr 2021 09:04:55 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) |
Hi Kyle and Arne,
Kyle Meyer <kyle@kyleam.com> writes:
> I'm not an ox-rss user and don't know if there are more realistic ways
> to hit this error, but I was able to trigger it by taking an already
> exported buffer of
>
> * h1
> :PROPERTIES:
> :ID: 76841adc-b233-4f6d-8446-3478f263544b
> :PUBDATE: <2021-01-10 Sun 17:46>
> :END:
>
> and then setting PUBDATE to an empty string and exporting again.
>
> I'm not sure if the error you see is indicative of a larger issue,
> though either way guarding against an empty string as your patch does
> seems fine.
Indeed, thanks Arne for reporting this.
> Also, a bit downstream I see
>
> (if (not pubdate0) "" ;; Skip entries with no PUBDATE prop
>
> It seems like this should be updated to look at pubdate rather than
> pubdate0 to avoid "<pubDate>nil</pubDate>" for the empty string
> case.
Indeed too. Applied as commit 8ab1e30db in maint.
Thanks,
--
Bastien
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: Bug: [patch] fix: ox-rss died when an entry had an empty date [ ( @ /home/arne/.guix-profile/share/emacs/site-lisp/)],
Bastien <=