|
From: | Thomas S. Dye |
Subject: | Re: [PATCH] LaTeX export: arbitrary float environments |
Date: | Sat, 01 May 2021 07:20:25 -1000 |
User-agent: | mu4e 1.2.0; emacs 26.3 |
Aloha Timothy, Thanks for your kind response.Sorry for the clumsy patch, which I guess would also benefit from an addition to the manual, as well?
Larger question: do we really want to tinker with ob-latex in this way? Or, should changes like this patch follow a path indicated by Tim Cross and into their own package, say ob-latex-ex, which might someday replace ob-latex if it proved useful and stable?
All the best, Tom Timothy <tecosaur@gmail.com> writes:
Hi Thomas, On the surface, this looks reasonable to me :) Just commenting on some technicalities with the patch itself:- In ORG-NEWS it would be good to wrap the content over multiple linesinstead of having a single 270 char line :)- You seem to have an anomalous change to the ob-python :return entry - I don't think your patch subject follows the convention for Org, itshould be: "main file/feature: overall change summary" so, something like "ox-latex: allow for arbitrary float environments" rather than "LaTeX export: arbitrary float environments" Thanks for the patch :) Timothy
-- Thomas S. Dye https://tsdye.online/tsdye
[Prev in Thread] | Current Thread | [Next in Thread] |