emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] org-protocol: Fix missing '+' in js snippet


From: Maxim Nikulin
Subject: Re: [PATCH] org-protocol: Fix missing '+' in js snippet
Date: Sun, 2 May 2021 18:34:54 +0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1

On 30/04/2021 14:21, Bastien wrote:
Maxim Nikulin writes:
On 28/04/2021 12:40, Bastien wrote:

Would you like to volunteer as the maintainer for org-protocol.el?
For now org-protocol.el indicates that Sebastian Rose, the original
author, is the maintainer, but I don't think he would mind handing it
to someone else.

Let me rise an issue related to org protocol that I consider important enough. Test are not executed by default, so there is a chance that breaking changes will be committed untested. There are two options:

1. Add org-protocol to the list of loaded packaged. The drawback is that test run will not detect unintentional dependency of org core on org-protocol. 2. Add a separate command to Makefile that tests exclusively org-protocol and update testing/README with reminder concerning org-protocol.

I believe that variant 2 is better, but opinion of core maintainers and their workflow is certainly more important.

...
Example of my ignorance: I suspect, I did not recognize that
apostrophe needs special escaping in doc strings
https://orgmode.org/list/s4hsag$ogg$1@ciao.gmane.io/

By the way, the patch (I have updated it in meanwhile) is not tracked on https://updates.orgmode.org/. I could not figure out what was the difference from e.g. https://orgmode.org/list/s6c1cm$174s$1@ciao.gmane.io/ Should I file an issue at github?

Actually, I do not think, org-protocol requires a dedicated
maintainer. There are a few things that may be improved, but they
should be discussed at first. It seems, all current user already
managed to configure their handlers and prefer to not experiment any
more. So there is a little interest in this area.

I don't use org-protocol.el myself and I'd rather have someone using
it being able to reproduce bugs and help maintainers fix problems.

It is funny, but I am not an active org-protocol user as well. I tried it, then I decided to create a browser extension that extracts some metadata in addition to page title. Since I am not satisfied with capture quality yet, I have to inspect page structure often enough. That is why there is no point to minimize interaction (primary goal of org-protocol) and I usually copy result and call org-paste-subtree. Though I test from time to time that org-protocol is not broken in my extension. The goal of my patches to org-protocol is to avoid some surprises I have faced.

Since I use linux, I can not reproduce windows or mac problems. Extrapolation of linux issues is not always applicable.

There were ~10 threads related to org protocol issues over 1.5 years I have in local cache, so it is not a hot topic that deserves a maintainer. Do not worry.






reply via email to

[Prev in Thread] Current Thread [Next in Thread]