emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: bug#47088: org-w3m: handle w3m-image link information


From: Nick Savage
Subject: Re: bug#47088: org-w3m: handle w3m-image link information
Date: Thu, 6 May 2021 19:56:33 -0400
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.0

I haven't opened up the code yet to take a look, but I likely will take a crack at some of these items in the future as low-hanging fruit refactoring project.

On 5/6/21 6:05 PM, Boruch Baum wrote:
        (org-w3m-get-image-end): New function, for w3m-img links.

3] As mentioned in the patch, and in the commit message, there seem to
    be several functioned unused in the code base that could be
    candidates for removal...

         org-w3m-get-anchor-start
         org-w3m-no-prev-link-p
         org-w3m-get-prev-link-start

4] Additionally, in performing the merge I came across function
    org-string-nw-p, which seems to be an unnecessary duplicate of the
    emacs core function string-blank-p. It may be that historically you
    once needed your own home-made functions/macros, but now that emacs
    core has them, you may want to consider a refactor.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]