emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: org-refile.el: Fix test case (Squashed)


From: satotake
Subject: Re: org-refile.el: Fix test case (Squashed)
Date: Fri, 14 May 2021 03:20:51 +0900

Thank you for your response.

> Maybe I have missed something, but it seems 2 
> patches are not logically independent, second one touches the same code 
> to fix regression in tests. 
> If so, could you, please, squash both 
> patches into a single one (e.g. using git rebase --interactive)? 
Yes. They should be a single patch. I squashed them.

> Have you tried org-capture? 
Yes. Mostly I use org-capture, especially, for creating TODO tasks.
I sometimes start with fundamental-mode new buffer.
After writing some texts, I switch to org-mode and try to call refile.
I do not know why I do it by myself clearly but I tend to do it when I
do not have any clear goal for the file.

I see this issue not critical for now because I know why this happens 
and just save it anywhere temporarily to avoid it.
But when I was new to Emacs and org-mode, I did not have any idea.
Thus, at least, we should show friendly error message.


> Code around has at least one more problem: questionable behavior in the 
> case of indirect buffers (e.g. C-x 4 c). Refile targets cache, when 
> enabled, is not reused for indirect buffer.

In addition to your point, I found that we cannot refile internally even with

my patch. In other words, if we can cache and reuse it, error ("Please 
indicate a target file in the refile path") is raised
when we select it as refile target.
Probably, we need to some additional fixations.
It may be good to filter `files' which does not have `buffer-file-name'.






reply via email to

[Prev in Thread] Current Thread [Next in Thread]