[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: bug#47885: [PATCH] org-table-import: Make it more smarter for intera
From: |
Utkarsh Singh |
Subject: |
Re: bug#47885: [PATCH] org-table-import: Make it more smarter for interactive use |
Date: |
Wed, 02 Jun 2021 20:38:02 +0530 |
On 2021-06-02, 19:06 +0700, Maxim Nikulin <manikulin@gmail.com> wrote:
> Notice that for "C-u M-x org-table-import" heuristics is not necessary,
> the separator is specified explicitly. I see that your intention was to
> improve user interface of org-table-import, but actually you broke it by
> the "org-table-import: add file prompt" patch. I have not tried it, but
> my expectation is that user prompt can be customized while keeping all
> other things working. Maybe the docstring should be updated to make it
> more friendly to novices (like me while reviewing your patch).
Thanks for pointing out the error, locally you can fix it by (patches
for patches):
;;;###autoload
(defun org-table-import (file separator)
@@ -955,12 +971,13 @@ lines. It can have the following values:
- integer When a number, use that many spaces, or a TAB, as field separator.
- regexp When a regular expression, use it to match the separator."
(interactive (list (read-file-name "Import file: ")
- (prefix-numeric-value current-prefix-arg)))
+ current-prefix-arg))
Currently I am trying to refactor CSV parsing by applying techniques
used in pcsv library (MELPA package) which I think you will also enjoy
to play with!
--
Utkarsh Singh
http://utkarshsingh.xyz
- Re: bug#47885: [PATCH] org-table-import: Make it more smarter for interactive use, Maxim Nikulin, 2021/06/01
- Re: bug#47885: [PATCH] org-table-import: Make it more smarter for interactive use, Utkarsh Singh, 2021/06/01
- Re: bug#47885: [PATCH] org-table-import: Make it more smarter for interactive use, Maxim Nikulin, 2021/06/02
- Re: bug#47885: [PATCH] org-table-import: Make it more smarter for interactive use,
Utkarsh Singh <=
- Re: bug#47885: [PATCH] org-table-import: Make it more smarter for interactive use, Maxim Nikulin, 2021/06/02
- Re: bug#47885: [PATCH] org-table-import: Make it more smarter for interactive use, Utkarsh Singh, 2021/06/04
- Re: bug#47885: [PATCH] org-table-import: Make it more smarter for interactive use, Maxim Nikulin, 2021/06/05
- Re: bug#47885: [PATCH] org-table-import: Make it more smarter for interactive use, Utkarsh Singh, 2021/06/05
- Re: bug#47885: [PATCH] org-table-import: Make it more smarter for interactive use, Maxim Nikulin, 2021/06/09