[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: bug#12972: 24.3.50; Move `org-open-file' and associated code out of
From: |
Maxim Nikulin |
Subject: |
Re: bug#12972: 24.3.50; Move `org-open-file' and associated code out of Org mode |
Date: |
Wed, 2 Jun 2021 23:20:50 +0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 |
On 01/06/2021 13:56, Lars Ingebrigtsen wrote:
So I've now added this to Emacs 28 under the name
`mailcap-view-file'.
I am sorry if it is a false alarm. Feel free to close the bug again if
something changed recently in `start-process-shell-command' or if you
prefer to discuss the issue as another bug.
It seems that implementation of `mailcap-view-file' is unreliable due to
creation of unnecessary terminal session and it can cause obscure and
difficult to reproduce failures similar to
https://lists.gnu.org/archive/html/emacs-orgmode/2020-09/msg00195.html
https://lists.gnu.org/archive/html/emacs-orgmode/2020-06/msg00332.html
The thread is actually longer than it is shown in the archive interface.
Another lengthy discussion:
https://debbugs.gnu.org/cgi/bugreport.cgi?bug=44824
In Org latest change was required for compatibility reason:
https://code.orgmode.org/bzg/org-mode/commit/869b7a21b94ed112f6640c8f2711c2a68b661dea
Let-bind (process-connection-type nil) is a minimal required change to
avoid unnecessary terminal session. However it is not friendly to users
in the case when troubleshooting is required. `make-process' with
sentinel is hopefully better.
The following could be ignored since it likely requires significant
amount of work with unclear benefits.
1. `org-open-file' besides Org-specific stuff allows to specify precise
target inside the file. It can be quite useful, e.g.
okular --page 11 --find "some pattern" file.pdf
PDF files have internal anchors as well. I have no consistent vision how
to express additional "locators" in general API.
2. There are at least two sources of truth for MIME-handlers on linux
desktop that are not necessary synchronized. Info from extracted from
.desktop files may be configurable from desktop UI unlike mailcap.
Distros may have some instruments to mitigate discrepancies. Debian adds
entries from .desktop handlers to system-wide mailcap DB. Another
approach is to add to maicap greedy xdg-open handler that tries to guess
currently running desktop and pass arguments to appropriate command.
Maybe mailcap should be secondary MIME database in Emacs, not the
primary one.
3. Currently only file suffix is inspected to determine MIME type of a
file. libmagic (or file command) usually provides more precise info, so
it is possible to open an incorrectly named file.
4. Mailcap has more features that are not addressed in Emacs. They may
be handy if Emacs is launched in terminal on remote server. It might
allow e.g. to open PDF file using pdftotext handler.
- A buffer for command output should be created for "copiousoutput" option.
- A buffer should be created and terminal session should be enabled if
an entry "needsterminal".
- There are more substitutions than "%s". However I am unsure if it is
possible to provide more info than application can obtain from the file.
I think, it is intended for mail multipart messages and additional headers.
On the other hand mailcap handlers might expect safe file names (minimal
ASCII subset), users may have files with arbitrary names (national
charset or some special characters). I hope, almost all handlers do not
have such problem.
In summary, during launch of external command terminal session must be
suppressed. There is enough room for MIME-related improvements in Emacs
in general and in Org mode in particular.