|
From: | Sébastien Miquel |
Subject: | Re: [PATCH] Do not throw error when parameter of :tangle is not a string |
Date: | Thu, 8 Jul 2021 08:44:26 +0000 |
Hi, Jacopo De Simoi writes:
in the current master branch, if the parameter :tangle of a src block is not a string, tangling fails by throwing an error when calling `file-name- directory' This patch checks if the parameter is a string before calling `file-name-directory'. This makes construct such as :tangle (when condition-applies "filename") work again (as they did a few versions ago…)
Thanks for the patch. It looks good to me (had to run `dos2unix' to apply). To clarify, it fixes `:tangle (when condition-applies "filename")' when the condition doesn't apply, such as `(when nil "filename")'. Regards, -- Sébastien Miquel
[Prev in Thread] | Current Thread | [Next in Thread] |