org-datetree-insert-line and org-blank-before-new-entry

[Richard Walker]

A follow-up to the changes made to org-datetree-insert-line
in September 2020.

The definition now begins:

(defun org-datetree-insert-line (year &optional month day text)
  (delete-region (save-excursion (skip-chars-backward " \t\n") (point)) (point))
  (when (assq 'heading org-blank-before-new-entry)
    (insert "\n"))
    ...

I'm getting blank lines inserted before new entries, and
I found a couple of sources of advice for setting org-blank-before-new-entry
( 
https://emacs.stackexchange.com/questions/51117/org-mode-control-whether-m-ret-inserts-a-newline-or-not-for-plain-lists
and
https://stackoverflow.com/questions/28351465/emacs-orgmode-do-not-insert-line-between-headers
)
that say to do this:

(setf org-blank-before-new-entry '((heading . nil) (plain-list-item . nil)))

Such a setting seems to be consistent with the help text of
org-blank-before-new-entry, and what org--blank-before-heading-p
expects to find. But, having made this setting,
  (when (assq 'heading org-blank-before-new-entry)
    (insert "\n"))
still does the insertion, since (assq 'heading org-blank-before-new-entry)
is non-nil.

Change (assq 'heading org-blank-before-new-entry)
to (org--blank-before-heading-p) here?