Re: [PATCH] {the CORRECT patch}

[Christopher M. Miles]

Max Nikulin <manikulin@gmail.com> writes:

On 20/10/2021 16:58, Christopher M. Miles wrote:

Just update the email subject contains [PATCH] "Christopher M. Miles" writes: Mostly Emacs versions under macOS does not have compiled with DBus. Or still don't work even compiled with DBus even macOS installed dbus with homebrew. I'm under this situation and problem. Spend lot of time have not solution to solve this problem. So I give up on Emacs DBus support under macOS to make "notifications.el" work. I added patch on org-notify.el to make it invoke AppleScript command to display notifications. Hope it help some macOS users. [5. text/x-patch; 0001-org-attach.el-add-a-new-command-to-archive-web-page.patch]…

Christopher, the patch you attached is related to org-attach and e.g. handling of monolith links. Does it really solve some notification problem?

Bastien committed your earlier patch for notification through applescript (that does not protect backslashes in notification text):

b80b0a517de7be94c70d3d6537899a94ac046fab org-clock.el: Make org-notify support macOS notification

I would expect that dbus-related options has lower priority than applescript.

Sorry, I misplaced the patch attachment file. I will attach the correct one. Sorry about this. Because org-contrib has separated from org-mode. So I go into wrong directory.

This is a patch for org-contrib/lisp/org-notify.el. Thanks for reviewing.

<#secure method=pgpmime mode=sign>

0001-org-notify.el-Make-org-notify-action-notify-support-.patch
Description: Text Data

-- 
[ stardiviner ]
       I try to make every word tell the meaning that I want to express.

       Blog: https://stardiviner.github.io/
       IRC(freenode): stardiviner, Matrix: stardiviner
       GPG: F09F650D7D674819892591401B5DF1C95AE89AC3