emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [patch] fix ox-latex async export bug


From: Nicolas Goaziou
Subject: Re: [patch] fix ox-latex async export bug
Date: Mon, 29 Nov 2021 22:39:32 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)

Hello,

Sébastien Miquel <sebastien.miquel@posteo.eu> writes:

> Attached is a patch that applies the same fix where affected.

Thank you. It mostly looks good, but I have one nit.

> -      (lambda (file)
> -     (run-hook-with-args 'org-icalendar-after-save-hook file) nil))))
> +      '(lambda (file)
> +      (run-hook-with-args 'org-icalendar-after-save-hook file) nil))))

This is not really the same fix. You're quoting a lambda, which should
not be required if the problem disappeared. IOW, the true fix probably
belong in the `org-export-async-start' function.

WDYT?

Regards,
-- 
Nicolas Goaziou



reply via email to

[Prev in Thread] Current Thread [Next in Thread]