[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Report error in scheme evaluation
From: |
Felipe Lema |
Subject: |
Re: Report error in scheme evaluation |
Date: |
Wed, 22 Dec 2021 13:56:47 -0300 |
On Wednesday, 22 December 2021 11.54.33 -03 Ihor Radchenko wrote:
> Felipe Lema <felipelema@mortemale.org> writes:
>
> > I started using guile with Org Babel and I was a little confused that
> > errors weren't being reported. The attached patch will report the error the
> > same way as python evaluation does.
>
> The patch looks fine to me. Though never used scheme...
>
> The only thing that can be improved is copy-paste from ob-eval.el It
> might be better to split the compile-mode code into separate function
> and reuse it.
I can do that in a separate patch after this one is merged.
>
> > Let me know if I'm missing anything so this can be merged. It is correct to
> > report errors this way, right?
>
> Should be. Did you have a chance run the code for some time locally
> while actively playing around with scheme?
yup. Seems to work as I expected
>
> Best,
> Ihor
>
Thanks
Felipe