|
From: | Max Nikulin |
Subject: | Re: [PATCH] make test: Make failure results more verbose |
Date: | Sat, 15 Jan 2022 20:06:44 +0700 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 |
A couple of additional remarks. On 15/01/2022 19:52, Max Nikulin wrote:
On 02/01/2022 20:12, Ihor Radchenko wrote:Subject: [PATCH] make test: Make failure results more verboseAt first it was not clear to me that only *summary* of test results is affected.
Should not the variable be named BTEST_ERT_VERBOSE_SUMMARY instead of just BTEST_ERT_VERBOSE due to this reason?
I am unsure if this line or local.mk has priority. I am unsure the the following is better as well. BTEST_ERT_VERBOSE ?= yesI am not very familiar with Makefile conventions. Just followed the existing settings in the same file. All other BTEST_ERT_* settings just use "=".
I have found an example when "?=" is better. It is possible to export BTEST_ERT_VERBOSE from shell (or set in in the environment of continuous integration runner) and the value will not be overridden. Quick tests shell equivalent:
BTEST_ERT_VERBOSE= make test currently it have to be written only as make test-dirty BTEST_ERT_VERBOSE=
[Prev in Thread] | Current Thread | [Next in Thread] |