[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 3/3] ox-texinfo: Define definition commands using descript
From: |
Nicolas Goaziou |
Subject: |
Re: [PATCH v3 3/3] ox-texinfo: Define definition commands using description lists |
Date: |
Sun, 23 Jan 2022 01:02:10 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) |
Hello,
Jonas Bernoulli <jonas@bernoul.li> writes:
> +The Texinfo export back-end supports two approaches to writing Texinfo
> +definition commands. One of them is describe here, the other in
> +[[*Plain lists in Texinfo export]].
Typo: one of them is described here
> +(defvar org-texinfo--quoted-keys-regexp
> + (regexp-opt '("BS" "TAB" "RET" "ESC" "SPC" "DEL"
> + "LFD" "DELETE" "SHIFT" "Ctrl" "Meta" "Alt"
> + "Cmd" "Super" "UP" "LEFT" "RIGHT" "DOWN")
> + 'words)
> + "Regexp matching keys that have to be quoted using @key{KEY}.")
OK. This is the one missing from first patch.
> +(defun org-texinfo--massage-key-item (plain-list item args)
> + "In PLAIN-LIST modify ITEM based on ARGS.
> +Reformat ITEM's tag property and add findex and kindex entries to
> +its content. If the bullet is \"+\" then use \"@itemx\" and deal with
> +data from preceeding siblings that use such a bullet."
The last sentence is a left-over from the previous prototype.
> + (t
> + (org-element-set-contents
> + item (nconc
> + (mapcar (lambda (key) `(keyword (:key "KINDEX" :value ,key)))
> kindex)
> + (mapcar (lambda (cmd) `(keyword (:key "FINDEX" :value ,cmd)))
> findex)
> + (org-element-contents item))))))))
Indentation seems a bit off, otherwise, LGTM.
Regards,
--
Nicolas Goaziou