Re: [PATCH] Re: [BUG] org-cite: 10 second hang opening a ~4k org file with 10MB bibtex library

[psychosis]

Hello,
On So, Mär 20 2022 at 12:20:42 +0800, Ihor Radchenko 
<yantar92@gmail.com> wrote:

> I have seen your email. Persisting the cache between sessions is a 
> more
> tricky. It will require a dedicated effort - significantly more than 
> the
> few-liner patch here.

Ah, I am not programmer and made an uneducated assumption because of 
the names “org-persist”, “org-cite-basic--bibliography-cache” 
and “org-cite-basic--completion-cache”.

> I assume that your bibliography is much larger than 10Mb. Am I 
> correct?

Actually, it is only 2Mb (7000 entries). Probably there is a problem 
with the data structure of my .bib-file? I create it from Zotero and 
the BibLaTeX-export of the BetterBibTeX-Plugin.

> This is bad. Would you mind constructing a reproducer? (using the
> patched Org version)

I made a mistake, I inserted the changed cite-key on a new line, which 
does not work. Inserting the new key on the same line as the old one 
works. I don’t know if this is the intended behavior.

> 2. You may provide profiling information using M-x profiler-start M-x
> profiler-report and using ELP as I described in the previous messages.

I attached the profiler-reports and the ELP-reports for “emacs -Q” 
with and without the patch. I use the latest Emacs version, built  with 
“native-compilation” and “pgtk” (GNU Emacs 29.0.50, 
x86_64-pc-linux-gnu, GTK+ Version 3.24.31, cairo version 1.17.4; Org 
mode version 9.5.2, release_9.5.2-24-g668205) with an .org-file that 
only contains one citation and the location of the bibliography. The 
CPU is an Intel Core i5-3320M @ 2.60GHz × 4.

Thank you very much for your help! I should add, I am content with the 
improvement of the parsing time that your patch provides. So if you 
assume that the problem is only on my end, please attend to more 
pressing issues.


Kind regards

Paul

reports_with_patch.org
Description: Text document

reports_without_patch.org
Description: Text document