[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Re: Concatenate properties
From: |
Ihor Radchenko |
Subject: |
Re: [PATCH] Re: Concatenate properties |
Date: |
Fri, 13 May 2022 20:21:28 +0800 |
Tyler Grinn <tylergrinn@gmail.com> writes:
> Ihor Radchenko <yantar92@gmail.com> writes:
>
>> Note that your patch is >15LOC long and you need to sign the copyright
>> agreement with FSF in order to contribute. See
>> https://orgmode.org/worg/org-contribute.html#copyright
>
> I've already submitted a copyright assignment to the FSF in order to
> publish on ELPA. Do I need one specific to org-mode?
Nope. The ELPA one is good enough. Basically, Org has the same
requirement as Emacs (Org is a part of Emacs).
>>> +(defcustom org-property-separators nil
>>> ...
>>> + :group 'org-properties
>>> + :type '(alist :key-type string :value-type sexp))
>>
>> This defcustom type does not match what you described in the docstring.
>> You need something like :type '(alist :key-type (choice string (repeat
>> string)) :value-type string)
>
> Setting ':value-type string' is confusing, in my opinion, because the
> default single space looks like: in the customization buffer, which is
> indistinguishable from no space: . I just found out about the restricted-sexp
> type, which I think makes the customization buffer more user-friendly.
restricted-sexp is fine. Though you could also do something like
(choice (const :tag "Single space" " ") (string :tag "Other string"))
> From f474cb25840fdc6b24618b1452cb7fdd32545092 Mon Sep 17 00:00:00 2001
> From: Tyler Grinn <tylergrinn@gmail.com>
> Date: Mon, 9 May 2022 15:52:58 -0400
> Subject: [PATCH] lisp/org.el: Add org-property-separators option
LGTM!
I will leave this for another week to give other people a chance to
comment.
For reference, this patch might be useful in
https://orgmode.org/list/87o821dv7o.fsf@localhost
Best,
Ihor
- Re: Concatenate properties, (continued)
- Re: Concatenate properties, John Kitchin, 2022/05/07
- Re: Concatenate properties, Tyler Grinn, 2022/05/07
- Re: Concatenate properties, Ihor Radchenko, 2022/05/08
- Re: Concatenate properties, Tyler Grinn, 2022/05/08
- Re: Concatenate properties, Ihor Radchenko, 2022/05/08
- Re: Concatenate properties, Tyler Grinn, 2022/05/09
- Re: Concatenate properties, Ihor Radchenko, 2022/05/11
- [PATCH] Re: Concatenate properties, Tyler Grinn, 2022/05/11
- Re: [PATCH] Re: Concatenate properties, Ihor Radchenko, 2022/05/12
- Re: [PATCH] Re: Concatenate properties, Tyler Grinn, 2022/05/12
- Re: [PATCH] Re: Concatenate properties,
Ihor Radchenko <=
- Re: [PATCH] Re: Concatenate properties, Tyler Grinn, 2022/05/13
- Re: [PATCH] Re: Concatenate properties, Ihor Radchenko, 2022/05/20
- Re: Concatenate properties, John Kitchin, 2022/05/07
- Re: Concatenate properties, Tyler Grinn, 2022/05/07