[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: oc-basic: CSL-JSON year as number vs. string (nativecomp?)
From: |
Ihor Radchenko |
Subject: |
Re: oc-basic: CSL-JSON year as number vs. string (nativecomp?) |
Date: |
Tue, 21 Jun 2022 11:28:34 +0800 |
David Lukeš <dafydd.lukes@gmail.com> writes:
>> Would you mind creating a patch and possibly supplying a test
>> that will make sure that the example file and similar are correctly
>> parsed?
>
> I'm attaching a patch (just the patch for now, no commit message), let
> me know what you think, in particular the error message. What would be
> an acceptable way to wrap the format string?
LGTM! There is no need to wrap the format string.
> As for tests -- if `oc-basic.el` already had some, I'd try to see if I
> can come up with something by analogy. But as it stands, I know too
> little about Elisp, nothing about Elisp testing, and have too little
> spare time, sorry :(
No problem. Your patch is already helpful.
Best,
Ihor
- oc-basic: CSL-JSON year as number vs. string (nativecomp?), David Lukeš, 2022/06/18
- Re: oc-basic: CSL-JSON year as number vs. string (nativecomp?), Ihor Radchenko, 2022/06/18
- Re: oc-basic: CSL-JSON year as number vs. string (nativecomp?), Bruce D'Arcus, 2022/06/18
- Re: oc-basic: CSL-JSON year as number vs. string (nativecomp?), David Lukeš, 2022/06/18
- Re: oc-basic: CSL-JSON year as number vs. string (nativecomp?), Bruce D'Arcus, 2022/06/19
- Re: oc-basic: CSL-JSON year as number vs. string (nativecomp?), Ihor Radchenko, 2022/06/20
- Re: oc-basic: CSL-JSON year as number vs. string (nativecomp?), Bruce D'Arcus, 2022/06/20
- Re: oc-basic: CSL-JSON year as number vs. string (nativecomp?), David Lukeš, 2022/06/20
- Re: oc-basic: CSL-JSON year as number vs. string (nativecomp?), Bruce D'Arcus, 2022/06/20
- Re: oc-basic: CSL-JSON year as number vs. string (nativecomp?),
Ihor Radchenko <=
- Re: oc-basic: CSL-JSON year as number vs. string (nativecomp?), David Lukeš, 2022/06/21
- Re: oc-basic: CSL-JSON year as number vs. string (nativecomp?), Ihor Radchenko, 2022/06/20